Some changes occurred in compiler/rustc_codegen_llvm/src/builder/autodiff.rs

cc @ZuseZ4

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

If this code works, then you should also be able to remove some more code, as per:

Is rustc_monomorphize::collector::autodiff::collect_autodiff_fn even necessary in the first place. The catch_unwind intrinsic also needs the function arguments to be codegened, yet it doesn't have any special casing in the monomorphization collector. Enzyme needs the function to differentiate to be in the same module, but I would expect fat LTO to run early enough to already cause that to happen. If you remove collect_autodiff_fn then I would assume this special case in cross_crate_inlineable isn't necessary either.

I marked the locations as fixme in https://github.com/rust-lang/rust/pull/149033/files

Also, did you verify that the test cases still pass with your changes? Here are the instructions to do so:
https://rustc-dev-guide.rust-lang.org/autodiff/installation.html#build-instructions

r? me

Sounds good, I will update the code and ensure it will pass the test cases.

Hi there, I checked out this commit, which is the last commit before I made the commits in this PR.

I tried to follow the build steps in this link you gave: https://rustc-dev-guide.rust-lang.org/autodiff/installation.html#build-instructions, but the build fails with errors due to being unable to compile core and rustc-demangle. Both errors are caused by "process didn't exit successfully" and have this at the end: exit code: 0xc0000005, STATUS_ACCESS_VIOLATION.

Could you please help with this issue?